feat: fetch and alt mime types for markdown #45

treadful · 2025-10-21T06:42:00Z

treadful commented

2025-10-21 06:42:00 +00:00

This PR got out of hand.

implements text/plain and application/octet-stream for fetching markdown files
implements jot fetch
adds PathJoin trait for making path strings
refactors server routes into their own modules
other minor shit

Closes #19

This PR got out of hand. - implements text/plain and application/octet-stream for fetching markdown files - implements `jot fetch` - adds PathJoin trait for making path strings - refactors server routes into their own modules - other minor shit Closes #19

treadful added the

feature

label

2025-10-21 06:42:00 +00:00

treadful added 1 commit

2025-10-21 06:42:01 +00:00

feat: implements text/plain and application/octet-stream fetching for markdown files

/ test-and-check (pull_request) Successful in 17m8s

Details

6c464abe7f

treadful added 1 commit

2025-10-21 07:18:58 +00:00

feat: impl PathJoin for &str

/ test-and-check (pull_request) Successful in 2m9s

Details

666714c9b2

treadful added 1 commit

2025-10-21 07:25:52 +00:00

style: func ordering

/ test-and-check (pull_request) Successful in 2m7s

Details

6c855e4a3a

treadful added 1 commit

2025-10-21 07:34:53 +00:00

style: match > if

/ test-and-check (pull_request) Successful in 2m18s

Details

8b7045ded2

treadful reviewed

2025-10-21 07:47:07 +00:00

treadful left a comment

This entire thing depends on local file paths when it's very likely this would be used to fetch when local files do not exist. This either requires prior knowledge, or fudging your way through paths given by jot objects. Walking the directory is also useless in this case.

It would also not be useful in the case of multiple clients using the same key. For instance, Alice updates x.text and Bob fetches it. Bob would have to have prior knowledge of the file.

Consider refactoring this entire thing to work off a list objects response from the server instead of local file paths. Though it would still need to work on local filesytem paths...

Use cases:

Alice accidentally deleted test.txt. Alice runs jot fetch test.txt
Bob copied his key from his old computer to his new one. He wants to fetch the entire contents of the directory again (assuming the same path on disk). jot fetch /home/bob/jot
Chris and Diane share a key and use it to collaborate on some notes. Chris makes an update, Diane intends to fetch it, so she runs jot fetch .

This PR would work for 1, and not for 2 and 3.

This entire thing depends on local file paths when it's very likely this would be used to fetch when local files do not exist. This either requires prior knowledge, or fudging your way through paths given by `jot objects`. Walking the directory is also useless in this case. It would also not be useful in the case of multiple clients using the same key. For instance, Alice updates `x.text` and Bob fetches it. Bob would have to have prior knowledge of the file. Consider refactoring this entire thing to work off a list objects response from the server instead of local file paths. Though it would still need to work on local filesytem paths... Use cases: 1) Alice accidentally deleted `test.txt`. Alice runs `jot fetch test.txt` 2) Bob copied his key from his old computer to his new one. He wants to fetch the entire contents of the directory again (assuming the same path on disk). `jot fetch /home/bob/jot` 3) Chris and Diane share a key and use it to collaborate on some notes. Chris makes an update, Diane intends to fetch it, so she runs `jot fetch .` This PR would work for 1, and not for 2 and 3.

jot-server/src/main.rs Outdated

					
				@ -200,28 +200,104 @@ async fn key_path(req: &mut Request, res: &mut Response) {

				    let short_id = req.param::<String>("short_id").unwrap();

				    let subpath = req.param::<String>("subpath").unwrap();

				    // TODO: break this whole block up

this worth doing now?

treadful marked this conversation as resolved

jot/src/join.rs Outdated

					
				@ -0,0 +1,81 @@

				pub trait PathJoin {

document this

treadful marked this conversation as resolved

treadful commented

2025-10-21 22:56:12 +00:00

@treadful wrote in #45 (comment):

Consider refactoring this entire thing to work off a list objects response from the server instead of local file paths. Though it would still need to work on local filesytem paths...

Also, jot objects should list full local paths as well.

@treadful wrote in https://source.treadful.dev/treadful/jot/pulls/45#issuecomment-268: > Consider refactoring this entire thing to work off a list objects response from the server instead of local file paths. Though it would still need to work on local filesytem paths... Also, `jot objects` should list full local paths as well.

treadful added 2 commits

2025-10-22 06:12:48 +00:00

fix: allow delete of remote files that do not exist locally c0b4a0c626

fix: when listing objects, show their local path representations

/ test-and-check (pull_request) Successful in 2m25s

Details

6724029991

treadful added 2 commits

2025-10-24 05:12:30 +00:00

feat: impl PathJoin for PathBuf 241d21236a

refactor: fetch command is now based on remote objects, not local files

/ test-and-check (pull_request) Successful in 2m51s

Details

8a038939bd

treadful added 1 commit

2025-10-25 01:12:17 +00:00

docs: minor documentation for PathJoin trait

/ test-and-check (pull_request) Successful in 2m58s

Details

e9374464e8

treadful added 1 commit

2025-10-25 05:54:22 +00:00

refactor: move most of the route logic to routes module

/ test-and-check (pull_request) Successful in 2m46s

Details

407e2f8d74

treadful changed title from ~~feat: implements text/plain and application/octet-stream fetching for markdown files~~ to feat: fetch and alt mime types for markdown

2025-10-25 06:03:41 +00:00

treadful merged commit a9d1367862 into main

2025-10-25 06:03:59 +00:00

treadful deleted branch feat/raw

2025-10-25 06:03:59 +00:00

treadful referenced this pull request from a commit

2025-10-25 06:04:01 +00:00

feat: fetch and alt mime types for markdown (#45)

treadful referenced this pull request

2025-10-25 06:05:16 +00:00

discussion: should jot objects return local filesystem paths? #46

Sign in to join this conversation.